update controllers logic

app/Http/Controllers/Api/Finance/PaymentManualController.php

@@ -2,7 +2,7 @@
 
 namespace App\Http\Controllers\Api\Finance;
 
-use App\Http\Controllers\Api\BaseApiController;
+use App\Http\Controllers\Api\Core\BaseApiController;
 use App\Http\Requests\Payments\PaymentManualEditRequest;
 use App\Http\Requests\Payments\PaymentManualUpdateRequest;
 use App\Services\Payments\PaymentManualService;
@@ -63,6 +63,11 @@ class PaymentManualController extends BaseApiController
 
     public function record(PaymentManualUpdateRequest $request, int $invoiceId): JsonResponse
     {
+        $guard = $this->authenticatedUserIdOrUnauthorized();
+        if ($guard instanceof JsonResponse) {
+            return $guard;
+        }
+
         $payload = $request->validated();
 
         $result = $this->service->recordPayment(
@@ -75,7 +80,7 @@ class PaymentManualController extends BaseApiController
             $request->file('payment_file'),
             $payload['school_year'] ?? null,
             $payload['semester'] ?? null,
-            (int) (auth()->id() ?? 0)
+            $guard
         );
 
         return response()->json(['ok' => true] + $result);
@@ -83,6 +88,11 @@ class PaymentManualController extends BaseApiController
 
     public function edit(PaymentManualEditRequest $request, int $paymentId): JsonResponse
     {
+        $guard = $this->authenticatedUserIdOrUnauthorized();
+        if ($guard instanceof JsonResponse) {
+            return $guard;
+        }
+
         $payload = $request->validated();
 
         $this->service->editPayment(
@@ -91,7 +101,7 @@ class PaymentManualController extends BaseApiController
             (string) $payload['payment_method'],
             $payload['check_number'] ?? null,
             $request->file('payment_file'),
-            (int) (auth()->id() ?? 0)
+            $guard
         );
 
         return response()->json(['ok' => true]);
@@ -102,4 +112,17 @@ class PaymentManualController extends BaseApiController
         $mode = (string) ($request->query('mode') ?? 'download');
         return $this->service->serveCheckFile($filename, $mode);
     }
+
+    /**
+     * @return int|JsonResponse
+     */
+    private function authenticatedUserIdOrUnauthorized(): int|JsonResponse
+    {
+        $userId = (int) (auth()->id() ?? 0);
+        if ($userId <= 0) {
+            return response()->json(['ok' => false, 'message' => 'Unauthorized.'], 401);
+        }
+
+        return $userId;
+    }
 }