update controllers logic

2026-04-23 00:04:35 -04:00
parent 1977a513df
commit ca4ba272fc
353 changed files with 13402 additions and 1301 deletions
@@ -2,7 +2,7 @@

 namespace App\Http\Controllers\Api\Finance;

-use App\Http\Controllers\Api\BaseApiController;
+use App\Http\Controllers\Api\Core\BaseApiController;
 use App\Http\Requests\Invoices\InvoiceManagementRequest;
 use App\Http\Requests\Invoices\InvoiceParentRequest;
 use App\Http\Requests\Invoices\InvoiceStatusRequest;
@@ -88,9 +88,9 @@ class InvoiceController extends BaseApiController

    public function parentPayment(InvoiceParentRequest $request): JsonResponse
    {
-        $parentId = (int) (auth()->id() ?? 0);
-        if ($parentId <= 0) {
-            return response()->json(['ok' => false, 'message' => 'Unauthorized.'], 401);
+        $parentId = $this->authenticatedUserIdOrUnauthorized();
+        if ($parentId instanceof JsonResponse) {
+            return $parentId;
        }

        $schoolYear = $request->validated()['school_year'] ?? null;
@@ -136,4 +136,17 @@ class InvoiceController extends BaseApiController
            echo $pdfBytes;
        }, 'invoice_' . $invoiceId . '.pdf', ['Content-Type' => 'application/pdf']);
    }
+
+    /**
+     * @return int|JsonResponse
+     */
+    private function authenticatedUserIdOrUnauthorized(): int|JsonResponse
+    {
+        $userId = (int) (auth()->id() ?? 0);
+        if ($userId <= 0) {
+            return response()->json(['ok' => false, 'message' => 'Unauthorized.'], 401);
+        }
+
+        return $userId;
+    }
 }