fix school year for all tables

app/Controllers/View/PaymentController.php

@@ -297,6 +297,8 @@ class PaymentController extends ResourceController
         $payments   = [];
         $invoices   = [];
         $pager      = null;
+        $carryForwardPaymentRequired = false;
+        $carryForwardPaymentMessage = '';
 
         // Read the search term (email or phone)
         $searchTerm = trim((string) $this->request->getGet('search_term'));
@@ -351,6 +353,10 @@ class PaymentController extends ResourceController
             if ($parent && !empty($parent['id'])) {
                 $parentData = $parent;
                 $parentId   = (int) $parent['id'];
+                $carryForwardPaymentRequired = $this->parentHasActiveCarryForwardBalance($parentId, $this->schoolYear);
+                if ($carryForwardPaymentRequired) {
+                    $carryForwardPaymentMessage = 'This parent has a balance carried over from a previous school year. Manual payments must be paid in full; installments are not allowed.';
+                }
 
                 // Students
                 $students = $this->studentModel
@@ -461,6 +467,8 @@ class PaymentController extends ResourceController
             'searchTermUsedInSearch' => $searchTerm,
             'todayYmd'               => utc_now(),
             'installmentEndYmd'      => $installmentEndYmd, // SELECT will use this in data-end-date
+            'carryForwardPaymentRequired' => $carryForwardPaymentRequired,
+            'carryForwardPaymentMessage' => $carryForwardPaymentMessage,
         ]);
     }
 
@@ -952,6 +960,15 @@ class PaymentController extends ResourceController
             // Recompute invoice totals from tuition + events + additional charges
             $currentBalance = (float) $this->invoiceLedgerService->recalculateInvoice($invoiceId)['balance'];
 
+            $carryForwardPaymentRequired = $this->parentHasActiveCarryForwardBalance($parentId, $invYear);
+            if ($carryForwardPaymentRequired && $paymentType === 'installment') {
+                $this->db->transRollback();
+                return redirect()->back()->withInput()->with(
+                    'error',
+                    'This parent has a balance carried over from a previous school year. Installments are not allowed; payment must be made in full.'
+                );
+            }
+
             if ($amount > $currentBalance + 0.00001) {
                 $this->db->transRollback();
                 return redirect()->back()->withInput()->with(
@@ -960,6 +977,14 @@ class PaymentController extends ResourceController
                 );
             }
 
+            if ($carryForwardPaymentRequired && (float)round($amount, 2) !== (float)round($currentBalance, 2)) {
+                $this->db->transRollback();
+                return redirect()->back()->withInput()->with(
+                    'error',
+                    'This parent has a balance carried over from a previous school year. Payment must equal the full remaining balance (' . number_format($currentBalance, 2) . ').'
+                );
+            }
+
             if ($paymentMethod === 'card' && (float)round($amount, 2) !== (float)round($currentBalance, 2)) {
                 $this->db->transRollback();
                 return redirect()->back()->withInput()->with(
@@ -1158,6 +1183,36 @@ class PaymentController extends ResourceController
         }
     }
 
+    private function parentHasActiveCarryForwardBalance(int $parentId, ?string $schoolYear = null): bool
+    {
+        if ($parentId <= 0 || ! $this->db->tableExists('invoices')) {
+            return false;
+        }
+
+        $builder = $this->db->table('invoices')
+            ->where('parent_id', $parentId)
+            ->where('balance >', 0);
+
+        if ($schoolYear !== null && $schoolYear !== '') {
+            $builder->where('school_year', $schoolYear);
+        }
+
+        $builder->groupStart()
+            ->like('invoice_number', 'CF-', 'after')
+            ->orWhere('semester', 'Opening Balance');
+
+        if ($this->db->fieldExists('description', 'invoices')) {
+            $builder
+                ->orLike('description', 'carried over')
+                ->orLike('description', 'carry-forward')
+                ->orLike('description', 'previous school year');
+        }
+
+        $builder->groupEnd();
+
+        return $builder->countAllResults() > 0;
+    }
+
 
     /**
      * 🔄 Helper: Recalculate invoice totals and status based on all payments for current school year