fix cicd issues
Build & Push / Pipeline Tests (push) Successful in 2m1s
Test / Type Check (all packages) (push) Successful in 55s
Build & Push / Build & Push Docker Image (push) Successful in 3m30s
Test / API Unit Tests (push) Successful in 1m16s
Test / Homepage Unit Tests (push) Successful in 50s
Test / Carplace Unit Tests (push) Successful in 43s
Test / Admin Unit Tests (push) Successful in 42s
Test / Dashboard Unit Tests (push) Successful in 46s
Test / API Integration Tests (push) Successful in 1m10s

This commit is contained in:
root
2026-08-12 17:21:28 -04:00
parent d616621bb6
commit 4a6df3dcba
6 changed files with 41 additions and 42 deletions
+4 -4
View File
@@ -8,7 +8,7 @@ Source of truth:
- `apps/dashboard/src/components/*`
- `apps/dashboard/src/lib/*`
- `apps/dashboard/src/hooks/*`
- `apps/dashboard/src/middleware.ts`
- `apps/dashboard/src/proxy.ts`
- `apps/dashboard/next.config.js`
## Purpose
@@ -93,7 +93,7 @@ apps/dashboard/
preferences.ts language/theme persistence scoped per employee
dashboardPaths.ts normalizes basePath-aware routes
urls.ts resolves Carplace/admin app links
src/middleware.ts auth gate and redirect logic
src/proxy.ts auth gate and redirect logic (Next.js 16 proxy convention)
```
## Rendering Strategy
@@ -136,7 +136,7 @@ The sign-in page also supports:
### Protected-route middleware
`src/middleware.ts` protects the app.
`src/proxy.ts` protects the app.
Important behavior:
@@ -691,7 +691,7 @@ Tradeoffs of this approach:
When changing the dashboard, keep these rules in mind:
1. Preserve the `/dashboard` base path and `toDashboardAppPath` normalization behavior.
2. Keep route protection aligned with `src/middleware.ts`.
2. Keep route protection aligned with `src/proxy.ts`.
3. If a new page depends on employee role, gate it both in navigation and in-page behavior.
4. Reuse `apiFetch` for auth and error handling consistency.
5. Keep language/theme strings inside the dashboard i18n system rather than scattering literals.