Fixed many feature failures around preferences, route coverage, administrator enrollment, assignment section names, attendance tracking controller access, finance PDF generation, and finance notification logging.

2026-07-07 21:26:47 -04:00
parent e13df69885
commit e0dfc3ec82
46 changed files with 19799 additions and 75 deletions
@@ -7,9 +7,12 @@ use Illuminate\Http\UploadedFile;

 class ExpenseReceiptService
 {
-    public function __construct(
-        private ApplicationUrlService $urls
-    ) {}
+    private ApplicationUrlService $urls;
+
+    public function __construct(?ApplicationUrlService $urls = null)
+    {
+        $this->urls = $urls ?? app(ApplicationUrlService::class);
+    }

    public function storeReceipt(UploadedFile $file): string
    {
@@ -41,6 +44,12 @@ class ExpenseReceiptService

    public function receiptUrl(?string $filename): ?string
    {
-        return $this->urls->forReceiptStorage($filename);
+        if (! $filename) {
+            return null;
+        }
+
+        $safe = basename(trim($filename));
+
+        return $safe !== '' ? url('receipts/'.$safe) : null;
    }
 }