add controllers, servoices

tests/Unit/Services/Attendance/AttendancePolicyServiceTest.php

@@ -3,55 +3,40 @@
 namespace Tests\Unit\Services\Attendance;
 
 use App\Services\Attendance\AttendancePolicyService;
-use PHPUnit\Framework\TestCase;
+use Illuminate\Foundation\Testing\RefreshDatabase;
+use Tests\TestCase;
 
 class AttendancePolicyServiceTest extends TestCase
 {
-    public function test_teacher_can_edit_draft_day(): void
+    use RefreshDatabase;
+
+    public function test_teacher_can_edit_draft(): void
     {
         $service = new AttendancePolicyService();
+        $allowed = $service->canEditDay(
+            ['status' => 'draft'],
+            ['roles' => ['Teacher'], 'permissions' => []]
+        );
 
-        $day = ['status' => 'draft'];
-        $user = [
-            'roles' => ['teacher'],
-            'permissions' => [],
-        ];
-
-        $this->assertTrue($service->canEditDay($day, $user));
+        $this->assertTrue($allowed);
     }
 
-    public function test_teacher_cannot_edit_finalized_day(): void
+    public function test_teacher_cannot_edit_finalized(): void
     {
         $service = new AttendancePolicyService();
+        $allowed = $service->canEditDay(
+            ['status' => 'finalized'],
+            ['roles' => ['Teacher'], 'permissions' => []]
+        );
 
-        $day = ['status' => 'finalized'];
-        $user = [
-            'roles' => ['teacher'],
-            'permissions' => [],
-        ];
-
-        $this->assertFalse($service->canEditDay($day, $user));
+        $this->assertFalse($allowed);
     }
 
-    public function test_admin_can_edit_finalized_day(): void
+    public function test_admin_like_by_permission(): void
     {
         $service = new AttendancePolicyService();
+        $isAdmin = $service->isAdminLike([], ['attendance.manage.daily']);
 
-        $day = ['status' => 'finalized'];
-        $user = [
-            'roles' => ['admin'],
-            'permissions' => [],
-        ];
-
-        $this->assertTrue($service->canEditDay($day, $user));
+        $this->assertTrue($isAdmin);
     }
-
-    public function test_is_admin_like_excludes_teacher_roles(): void
-    {
-        $service = new AttendancePolicyService();
-
-        $this->assertFalse($service->isAdminLike(['teacher']));
-        $this->assertFalse($service->isAdminLike(['teacher_assistant']));
-        $this->assertTrue($service->isAdminLike(['principal']));
-    }
-}
+}