archetecture security fix

app/Services/Administrator/TeacherSubmissionReportService.php

@@ -21,8 +21,9 @@ class TeacherSubmissionReportService
     {
         $semester = $this->shared->getSemester($filters['semester'] ?? null);
         $schoolYear = $this->shared->getSchoolYear($filters['school_year'] ?? null);
+        $teacherClassSupportsSemester = $this->shared->teacherClassSupportsSemester();
 
-        $assignmentRows = DB::table('teacher_class as tc')
+        $assignmentQuery = DB::table('teacher_class as tc')
             ->select([
                 'tc.class_section_id',
                 'cs.class_section_name',
@@ -34,8 +35,13 @@ class TeacherSubmissionReportService
             ->leftJoin('classSection as cs', 'cs.class_section_id', '=', 'tc.class_section_id')
             ->leftJoin('users as u', 'u.id', '=', 'tc.teacher_id')
             ->where('tc.school_year', $schoolYear)
-            ->where('tc.semester', $semester)
-            ->orderBy('cs.class_section_name')
+            ->orderBy('cs.class_section_name');
+
+        if ($teacherClassSupportsSemester && $semester !== '') {
+            $assignmentQuery->where('tc.semester', $semester);
+        }
+
+        $assignmentRows = $assignmentQuery
             ->get()
             ->map(fn ($r) => (array) $r)
             ->all();