fix logic and tests, update docker CI file

app/Http/Controllers/Api/Finance/InvoiceController.php

@@ -3,7 +3,6 @@
 namespace App\Http\Controllers\Api\Finance;
 
 use App\Http\Controllers\Api\BaseApiController;
-use App\Http\Requests\Invoices\InvoiceGenerateRequest;
 use App\Http\Requests\Invoices\InvoiceManagementRequest;
 use App\Http\Requests\Invoices\InvoiceParentRequest;
 use App\Http\Requests\Invoices\InvoiceStatusRequest;
@@ -15,6 +14,8 @@ use App\Services\Invoices\InvoiceManagementService;
 use App\Services\Invoices\InvoicePaymentService;
 use App\Services\Invoices\InvoicePdfService;
 use Illuminate\Http\JsonResponse;
+use Illuminate\Http\Request;
+use Illuminate\Support\Facades\Validator;
 use Symfony\Component\HttpFoundation\StreamedResponse;
 
 class InvoiceController extends BaseApiController
@@ -44,9 +45,22 @@ class InvoiceController extends BaseApiController
         ]);
     }
 
-    public function generate(InvoiceGenerateRequest $request): JsonResponse
+    public function generate(Request $request): JsonResponse
     {
-        $payload = $request->validated();
+        $data = array_merge($request->query->all(), $request->all(), $request->json()->all());
+        $validator = Validator::make($data, [
+            'parent_id' => ['required', 'integer', 'exists:users,id'],
+            'school_year' => ['nullable', 'string', 'max:20'],
+        ]);
+
+        if ($validator->fails()) {
+            return response()->json([
+                'message' => 'Validation failed.',
+                'errors' => $validator->errors(),
+            ], 422);
+        }
+
+        $payload = $validator->validated();
         $result = $this->generation->generateInvoice((int) $payload['parent_id'], $payload['school_year'] ?? null);
 
         if (empty($result['ok'])) {