melabidi/alrahma_sunday_school_api
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix gitlab tests

Browse Source
This commit is contained in:
root
2026-06-09 02:32:58 -04:00
parent 20a0b6c4e5
commit 6def9993da
1489 changed files with 10449 additions and 11356 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/Feature/Api/V1/FullSurface/ApiDeepResponseShapeAndEnvelopeContractTest.php
+6 -8
View File
@@ -18,17 +18,16 @@ class ApiDeepResponseShapeAndEnvelopeContractTest extends FullSurfaceE2EContract
$status = $response->getStatusCode();
if ($status >= 500) {
$failures[] = "$method $uri crashed with $status: ".$response->getContent();
$failures[] = "$method $uri crashed with $status: " . $response->getContent();
continue;
}
if ($status >= 200 && $status < 300 && $response->getContent() !== '' && ! $this->isJsonString($response->getContent())) {
$failures[] = "$method $uri returned non-json successful API response: ".$response->getContent();
$failures[] = "$method $uri returned non-json successful API response: " . $response->getContent();
}
}
$this->assertSame([], $failures, "Successful API responses should be machine-readable JSON:\n".implode("\n", $failures));
$this->assertSame([], $failures, "Successful API responses should be machine-readable JSON:\n" . implode("\n", $failures));
}
public function test_collection_endpoints_expose_list_like_payloads_or_explicit_empty_state(): void
@@ -47,8 +46,7 @@ class ApiDeepResponseShapeAndEnvelopeContractTest extends FullSurfaceE2EContract
$status = $response->getStatusCode();
if (! in_array($status, [200, 204, 302, 401, 403, 404, 422], true)) {
$failures[] = "$method $uri returned unexpected $status for collection contract: ".$response->getContent();
$failures[] = "$method $uri returned unexpected $status for collection contract: " . $response->getContent();
continue;
}
@@ -64,12 +62,12 @@ class ApiDeepResponseShapeAndEnvelopeContractTest extends FullSurfaceE2EContract
|| array_key_exists('status', $payload));
if (! $hasCollectionShape) {
$failures[] = "$method $uri returned JSON but no recognizable collection/envelope keys: ".$response->getContent();
$failures[] = "$method $uri returned JSON but no recognizable collection/envelope keys: " . $response->getContent();
}
}
}
$this->assertSame([], $failures, "Collection routes need a stable list/envelope shape:\n".implode("\n", $failures));
$this->assertSame([], $failures, "Collection routes need a stable list/envelope shape:\n" . implode("\n", $failures));
}
/** @return list<LaravelRoute> */