fix gitlab tests
This commit is contained in:
@@ -31,7 +31,7 @@ class AssignmentDataLoaderService
|
||||
->get()
|
||||
->map(function ($row) {
|
||||
$row->teacher_full_name = trim(
|
||||
((string) optional($row->teacher)->firstname).' '.
|
||||
((string) optional($row->teacher)->firstname) . ' ' .
|
||||
((string) optional($row->teacher)->lastname)
|
||||
);
|
||||
|
||||
|
||||
@@ -20,7 +20,6 @@ class AssignmentSectionService
|
||||
->get()
|
||||
->mapWithKeys(function ($section) {
|
||||
$name = $section->class_section_name ?? $section->section_name ?? $section->name ?? '';
|
||||
|
||||
return [(int) $section->class_section_id => (string) $name];
|
||||
})
|
||||
->all();
|
||||
|
||||
@@ -93,7 +93,7 @@ class AssignmentService
|
||||
]);
|
||||
|
||||
$students = $studentRows
|
||||
->filter(fn ($row) => ! empty($row->student))
|
||||
->filter(fn ($row) => !empty($row->student))
|
||||
->map(function ($row) {
|
||||
$student = $row->student;
|
||||
|
||||
@@ -122,10 +122,10 @@ class AssignmentService
|
||||
'description' => (string) $descriptionMeta,
|
||||
];
|
||||
})
|
||||
->filter()
|
||||
->sortBy('class_section_name', SORT_NATURAL | SORT_FLAG_CASE)
|
||||
->values()
|
||||
->all();
|
||||
->filter()
|
||||
->sortBy('class_section_name', SORT_NATURAL | SORT_FLAG_CASE)
|
||||
->values()
|
||||
->all();
|
||||
|
||||
return [
|
||||
'classSections' => $classSections,
|
||||
@@ -220,7 +220,7 @@ class AssignmentService
|
||||
]);
|
||||
|
||||
$students = $studentRows
|
||||
->filter(fn ($row) => ! empty($row->student))
|
||||
->filter(fn ($row) => !empty($row->student))
|
||||
->map(function ($row) {
|
||||
$student = $row->student;
|
||||
|
||||
@@ -249,10 +249,10 @@ class AssignmentService
|
||||
'description' => (string) $descriptionMeta,
|
||||
];
|
||||
})
|
||||
->filter()
|
||||
->sortBy('class_section_name', SORT_NATURAL | SORT_FLAG_CASE)
|
||||
->values()
|
||||
->all();
|
||||
->filter()
|
||||
->sortBy('class_section_name', SORT_NATURAL | SORT_FLAG_CASE)
|
||||
->values()
|
||||
->all();
|
||||
|
||||
return [
|
||||
'classSections' => $classSections,
|
||||
|
||||
Reference in New Issue
Block a user