add tests batch 20

This commit is contained in:
root
2026-06-09 01:03:53 -04:00
parent 95efb9652e
commit 6be4875c5e
1502 changed files with 13797 additions and 11313 deletions
@@ -8,7 +8,9 @@ use Illuminate\Support\Facades\DB;
class GradingOverviewService
{
public function __construct() {}
public function __construct()
{
}
public function overview(?int $classId, ?string $semester, ?string $schoolYear): array
{
@@ -36,7 +38,7 @@ class GradingOverviewService
continue;
}
if (! isset($grades[$classIdValue])) {
if (!isset($grades[$classIdValue])) {
$grades[$classIdValue] = [];
}
$exists = false;
@@ -46,7 +48,7 @@ class GradingOverviewService
break;
}
}
if (! $exists) {
if (!$exists) {
$grades[$classIdValue][] = [
'class_section_id' => $sectionId,
'class_section_name' => $sectionName,
@@ -246,7 +248,6 @@ class GradingOverviewService
if ($value === null || $value === '') {
return null;
}
return round((float) $value, 2);
}
@@ -259,7 +260,6 @@ class GradingOverviewService
return null;
}
}
return $score;
}
@@ -271,7 +271,6 @@ class GradingOverviewService
return $option;
}
}
return $requestedSemester;
}
if ($fallbackSemester !== null && $fallbackSemester !== '') {
@@ -280,10 +279,8 @@ class GradingOverviewService
return $option;
}
}
return $fallbackSemester;
}
return $semesterOptions[0] ?? '';
}
@@ -309,7 +306,7 @@ class GradingOverviewService
$semesters = ['Fall', 'Spring'];
}
if ($fallbackSemester !== null && $fallbackSemester !== '' && ! in_array($fallbackSemester, $semesters, true)) {
if ($fallbackSemester !== null && $fallbackSemester !== '' && !in_array($fallbackSemester, $semesters, true)) {
array_unshift($semesters, $fallbackSemester);
}
@@ -325,7 +322,6 @@ class GradingOverviewService
if ($norm === 'spring') {
return 'parent_scores_released_spring';
}
return null;
}
@@ -334,14 +330,13 @@ class GradingOverviewService
$key = $this->getParentReleaseKey($semester);
$raw = $key ? Configuration::getConfig($key) : null;
$raw = (string) ($raw ?? '');
return in_array(strtolower(trim($raw)), ['1', 'true', 'yes', 'y', 'on'], true);
}
private function ensureParentReleaseKeyExists(string $semester): void
{
$key = $this->getParentReleaseKey($semester);
if (! $key) {
if (!$key) {
return;
}