melabidi/alrahma_sunday_school_api
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix tests

Browse Source
This commit is contained in:
root
2026-06-11 11:46:12 -04:00
parent c91fa2ce4d
commit 5ead80fdc7
1489 changed files with 11349 additions and 10305 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/Services/Promotions/PromotionEnrollmentService.php
+17 -14
View File
@@ -28,8 +28,7 @@ class PromotionEnrollmentService
public function __construct(
private PromotionStatusService $statusService,
private PromotionAuditService $audit
) {
}
) {}
/**
* Lists actionable promotion records for a parent (the parent
@@ -54,9 +53,9 @@ class PromotionEnrollmentService
$studentIds = $records->pluck('student_id')->unique()->all();
/** @var EloquentCollection<int,Student> $studentsCollection */
$studentsCollection = !empty($studentIds)
$studentsCollection = ! empty($studentIds)
? Student::query()->whereIn('id', $studentIds)->get()
: new EloquentCollection();
: new EloquentCollection;
$studentsById = $studentsCollection->keyBy('id');
$payload = $records->map(function (StudentPromotionRecord $record) use ($studentsById) {
@@ -80,7 +79,7 @@ class PromotionEnrollmentService
$this->assertActionable($record);
return DB::transaction(function () use ($record, $parentId, $userId) {
if (!$record->enrollment_started_at) {
if (! $record->enrollment_started_at) {
$record->enrollment_started_at = now();
}
$record->enrollment_status = StudentPromotionRecord::ENROLLMENT_IN_PROGRESS;
@@ -117,7 +116,7 @@ class PromotionEnrollmentService
$sanitized = [];
foreach ($steps as $field => $value) {
if (!in_array($field, self::ALLOWED_STEPS, true)) {
if (! in_array($field, self::ALLOWED_STEPS, true)) {
continue;
}
$sanitized[$field] = (bool) $value;
@@ -139,7 +138,7 @@ class PromotionEnrollmentService
return $record;
}
if (!$record->enrollment_started_at) {
if (! $record->enrollment_started_at) {
$record->enrollment_started_at = now();
}
$record->enrollment_status = StudentPromotionRecord::ENROLLMENT_IN_PROGRESS;
@@ -185,7 +184,7 @@ class PromotionEnrollmentService
$this->assertParentOwns($record, $parentId);
$this->assertActionable($record);
if (!$record->enrollmentChecklistComplete()) {
if (! $record->enrollmentChecklistComplete()) {
throw new RuntimeException('Enrollment checklist is incomplete.');
}
@@ -294,10 +293,12 @@ class PromotionEnrollmentService
if ($existing) {
$existing->fill($payload);
$existing->save();
return (int) $existing->getKey();
}
$created = Enrollment::query()->create($payload);
return $created ? (int) $created->getKey() : null;
}
@@ -307,7 +308,7 @@ class PromotionEnrollmentService
'promotion_id' => (int) $record->getKey(),
'student_id' => (int) $record->student_id,
'student_name' => $student
? trim((string) $student->firstname . ' ' . (string) $student->lastname)
? trim((string) $student->firstname.' '.(string) $student->lastname)
: null,
'current_level' => $record->current_level_name,
'promoted_level' => $record->promoted_level_name,
@@ -343,12 +344,13 @@ class PromotionEnrollmentService
true
);
});
if (!$actionable) {
if (! $actionable) {
return null;
}
$level = $actionable->promoted_level_name ?: 'the next level';
$deadline = $actionable->enrollment_deadline?->toDateString();
$deadlineText = $deadline ? 'by ' . $deadline : 'as soon as possible';
$deadlineText = $deadline ? 'by '.$deadline : 'as soon as possible';
return sprintf(
'Your child is eligible for promotion to %s. Please complete enrollment for the new school year %s.',
$level,
@@ -372,7 +374,7 @@ class PromotionEnrollmentService
private function assertActionable(StudentPromotionRecord $record): void
{
$actionable = StudentPromotionRecord::parentActionableStatuses();
if (!in_array($record->promotion_status, $actionable, true)) {
if (! in_array($record->promotion_status, $actionable, true)) {
throw new RuntimeException(sprintf(
'Promotion record is not actionable in status "%s".',
$record->promotion_status
@@ -383,9 +385,10 @@ class PromotionEnrollmentService
private function guessNextSchoolYear(): ?string
{
$current = (string) (Configuration::getConfigValueByKey('school_year') ?? '');
if (!preg_match('/^(\d{4})-(\d{4})$/', $current, $m)) {
if (! preg_match('/^(\d{4})-(\d{4})$/', $current, $m)) {
return null;
}
return ((int) $m[1] + 1) . '-' . ((int) $m[2] + 1);
return ((int) $m[1] + 1).'-'.((int) $m[2] + 1);
}
}