fix tests

This commit is contained in:
root
2026-06-11 11:46:12 -04:00
parent c91fa2ce4d
commit 5ead80fdc7
1489 changed files with 11349 additions and 10305 deletions
@@ -99,7 +99,7 @@ class SchoolCalendarController extends BaseApiController
public function show(int $eventId): JsonResponse
{
$event = $this->queryService->findEvent($eventId);
if (!$event) {
if (! $event) {
return $this->error('Event not found.', Response::HTTP_NOT_FOUND);
}
@@ -116,7 +116,8 @@ class SchoolCalendarController extends BaseApiController
try {
$result = $this->mutationService->create($payload, $targets);
} catch (\Throwable $e) {
Log::error('SchoolCalendar store failed: ' . $e->getMessage());
Log::error('SchoolCalendar store failed: '.$e->getMessage());
return $this->error('Failed to save event.', Response::HTTP_INTERNAL_SERVER_ERROR);
}
@@ -129,7 +130,7 @@ class SchoolCalendarController extends BaseApiController
public function update(SchoolCalendarUpdateRequest $request, int $eventId): JsonResponse
{
$event = $this->queryService->findEvent($eventId);
if (!$event) {
if (! $event) {
return $this->error('Event not found.', Response::HTTP_NOT_FOUND);
}
@@ -139,7 +140,8 @@ class SchoolCalendarController extends BaseApiController
try {
$result = $this->mutationService->update($event, $payload, $targets);
} catch (\Throwable $e) {
Log::error('SchoolCalendar update failed: ' . $e->getMessage());
Log::error('SchoolCalendar update failed: '.$e->getMessage());
return $this->error('Failed to update event.', Response::HTTP_INTERNAL_SERVER_ERROR);
}
@@ -152,14 +154,15 @@ class SchoolCalendarController extends BaseApiController
public function destroy(int $eventId): JsonResponse
{
$event = $this->queryService->findEvent($eventId);
if (!$event) {
if (! $event) {
return $this->error('Event not found.', Response::HTTP_NOT_FOUND);
}
try {
$this->mutationService->delete($event);
} catch (\Throwable $e) {
Log::error('SchoolCalendar delete failed: ' . $e->getMessage());
Log::error('SchoolCalendar delete failed: '.$e->getMessage());
return $this->error('Failed to delete event.', Response::HTTP_INTERNAL_SERVER_ERROR);
}
@@ -169,15 +172,12 @@ class SchoolCalendarController extends BaseApiController
private function extractEmailTargets(array $payload): array
{
return [
'parents' => !empty($payload['send_email_parent']),
'teachers' => !empty($payload['send_email_teacher']),
'admins' => !empty($payload['send_email_admin']),
'parents' => ! empty($payload['send_email_parent']),
'teachers' => ! empty($payload['send_email_teacher']),
'admins' => ! empty($payload['send_email_admin']),
];
}
/**
* @return int|JsonResponse
*/
private function authenticatedUserIdOrUnauthorized(): int|JsonResponse
{
$userId = (int) (auth()->id() ?? 0);