melabidi/alrahma_sunday_school_api
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix tests

Browse Source
This commit is contained in:
root
2026-06-11 11:46:12 -04:00
parent c91fa2ce4d
commit 5ead80fdc7
1489 changed files with 11349 additions and 10305 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/Http/Controllers/Api/Reports/ReportCardsController.php
+11 -7
View File
@@ -52,7 +52,7 @@ class ReportCardsController extends BaseApiController
$classSectionId = (int) ($payload['class_section_id'] ?? 0);
$result = $this->service->completeness($schoolYear, $semester, $classSectionId);
if (!($result['ok'] ?? false)) {
if (! ($result['ok'] ?? false)) {
return $this->error($result['message'] ?? 'Unable to generate completeness report.', Response::HTTP_UNPROCESSABLE_ENTITY);
}
@@ -101,11 +101,12 @@ class ReportCardsController extends BaseApiController
try {
$result = $this->service->generateSingleReport($studentId, $request->validated());
} catch (\Throwable $e) {
Log::error('Report card PDF generation failed: ' . $e->getMessage());
Log::error('Report card PDF generation failed: '.$e->getMessage());
return $this->error('Failed to generate report card.', Response::HTTP_INTERNAL_SERVER_ERROR);
}
if (!($result['ok'] ?? false)) {
if (! ($result['ok'] ?? false)) {
return $this->error($result['message'] ?? 'Unable to generate report card.', Response::HTTP_UNPROCESSABLE_ENTITY);
}
@@ -113,7 +114,7 @@ class ReportCardsController extends BaseApiController
return response($result['pdf'], 200, [
'Content-Type' => 'application/pdf',
'Content-Disposition' => $disposition . '; filename="' . ($result['filename'] ?? 'ReportCard.pdf') . '"',
'Content-Disposition' => $disposition.'; filename="'.($result['filename'] ?? 'ReportCard.pdf').'"',
'Cache-Control' => 'private, max-age=0, must-revalidate',
'Pragma' => 'public',
]);
@@ -124,11 +125,12 @@ class ReportCardsController extends BaseApiController
try {
$result = $this->service->generateClassReport($classSectionId, $request->validated());
} catch (\Throwable $e) {
Log::error('Class report card PDF generation failed: ' . $e->getMessage());
Log::error('Class report card PDF generation failed: '.$e->getMessage());
return $this->error('Failed to generate class report cards.', Response::HTTP_INTERNAL_SERVER_ERROR);
}
if (!($result['ok'] ?? false)) {
if (! ($result['ok'] ?? false)) {
return $this->error($result['message'] ?? 'Unable to generate class report cards.', Response::HTTP_UNPROCESSABLE_ENTITY);
}
@@ -136,7 +138,7 @@ class ReportCardsController extends BaseApiController
return response($result['pdf'], 200, [
'Content-Type' => 'application/pdf',
'Content-Disposition' => $disposition . '; filename="' . ($result['filename'] ?? 'ClassReportCards.pdf') . '"',
'Content-Disposition' => $disposition.'; filename="'.($result['filename'] ?? 'ClassReportCards.pdf').'"',
'Cache-Control' => 'private, max-age=0, must-revalidate',
'Pragma' => 'public',
]);
@@ -148,6 +150,7 @@ class ReportCardsController extends BaseApiController
if ($value !== '') {
return $value;
}
return trim((string) (Configuration::getConfig('school_year') ?? ''));
}
@@ -157,6 +160,7 @@ class ReportCardsController extends BaseApiController
if ($value !== '') {
return $value;
}
return trim((string) (Configuration::getConfig('semester') ?? ''));
}
}
app/Http/Controllers/Api/Reports/SlipPrinterController.php
+4 -7
View File
@@ -27,13 +27,13 @@ class SlipPrinterController extends BaseApiController
$result = $this->service->print($request->validated(), $guard);
if (!$result['ok']) {
if (! $result['ok']) {
return response()->json(['ok' => false, 'message' => $result['message'] ?? 'Print failed.'], 422);
}
return response($result['pdf'], 200, [
'Content-Type' => 'application/pdf',
'Content-Disposition' => 'inline; filename="' . $result['filename'] . '"',
'Content-Disposition' => 'inline; filename="'.$result['filename'].'"',
]);
}
@@ -78,19 +78,16 @@ class SlipPrinterController extends BaseApiController
$result = $this->service->reprint((int) $request->validated()['id'], $guard);
if (!$result['ok']) {
if (! $result['ok']) {
return response()->json(['ok' => false, 'message' => $result['message'] ?? 'Slip not found.'], 404);
}
return response($result['pdf'], 200, [
'Content-Type' => 'application/pdf',
'Content-Disposition' => 'inline; filename="' . $result['filename'] . '"',
'Content-Disposition' => 'inline; filename="'.$result['filename'].'"',
]);
}
/**
* @return int|JsonResponse
*/
private function authenticatedUserIdOrUnauthorized(): int|JsonResponse
{
$userId = (int) (auth()->id() ?? 0);
app/Http/Controllers/Api/Reports/StickersController.php
+4 -3
View File
@@ -64,17 +64,18 @@ class StickersController extends BaseApiController
try {
$result = $this->printService->generate($request->validated());
} catch (\Throwable $e) {
Log::error('Sticker print failed: ' . $e->getMessage());
Log::error('Sticker print failed: '.$e->getMessage());
return $this->error('Failed to generate stickers.', Response::HTTP_INTERNAL_SERVER_ERROR);
}
if (!($result['ok'] ?? false)) {
if (! ($result['ok'] ?? false)) {
return $this->error($result['message'] ?? 'Unable to generate stickers.', Response::HTTP_UNPROCESSABLE_ENTITY);
}
return response($result['pdf'], 200, [
'Content-Type' => 'application/pdf',
'Content-Disposition' => 'inline; filename="' . ($result['filename'] ?? 'Student_Stickers.pdf') . '"',
'Content-Disposition' => 'inline; filename="'.($result['filename'] ?? 'Student_Stickers.pdf').'"',
]);
}
}