apply the school year concept

app/Controllers/View/StudentController.php

@@ -386,21 +386,8 @@ class StudentController extends BaseController
     {
         $schoolYear = (string)($this->schoolYear ?? '');
 
-        $activeStudents = $this->studentModel
-            ->select('id, school_id, firstname, lastname, gender, age')
-            ->where('is_active', 1)
-            ->orderBy('lastname', 'ASC')
-            ->orderBy('firstname', 'ASC')
-            ->findAll();
-
-        $removedStudents = $this->studentModel
-            ->select('id, school_id, firstname, lastname, gender, age')
-            ->where('is_active', 0)
-            ->orderBy('lastname', 'ASC')
-            ->orderBy('firstname', 'ASC')
-            ->findAll();
-
         $classMap = [];
+        $activeYearStudentIds = [];
         $classQuery = $this->db->table('student_class sc')
             ->select('sc.student_id, cs.class_section_name')
             ->join('classSection cs', 'cs.class_section_id = sc.class_section_id', 'left');
@@ -411,11 +398,35 @@ class StudentController extends BaseController
 
         foreach ($classRows as $row) {
             $sid = (int)($row['student_id'] ?? 0);
+            if ($sid > 0) {
+                $activeYearStudentIds[$sid] = true;
+            }
+
             $name = trim((string)($row['class_section_name'] ?? ''));
             if ($sid <= 0 || $name === '') continue;
             $classMap[$sid][] = $name;
         }
 
+        $students = $this->studentModel
+            ->select('id, school_id, firstname, lastname, gender, age, is_active')
+            ->orderBy('lastname', 'ASC')
+            ->orderBy('firstname', 'ASC')
+            ->findAll();
+
+        $activeStudents = [];
+        $removedStudents = [];
+        foreach ($students as $student) {
+            $studentId = (int)($student['id'] ?? 0);
+            $isGloballyActive = (int)($student['is_active'] ?? 0) === 1;
+            $hasSelectedYearClass = $studentId > 0 && isset($activeYearStudentIds[$studentId]);
+
+            if ($isGloballyActive && $hasSelectedYearClass) {
+                $activeStudents[] = $student;
+            } else {
+                $removedStudents[] = $student;
+            }
+        }
+
         $attachClassNames = static function (array $students) use ($classMap): array {
             foreach ($students as &$student) {
                 $sid = (int)($student['id'] ?? 0);
@@ -432,6 +443,7 @@ class StudentController extends BaseController
             'active_students'  => $attachClassNames($activeStudents),
             'removed_students' => $attachClassNames($removedStudents),
             'school_year'      => $schoolYear,
+            'active_school_year' => (string)($this->schoolYear ?? ''),
         ]);
     }
 
@@ -1671,8 +1683,7 @@ class StudentController extends BaseController
                     ->findAll();
             }
         } elseif (in_array($role, ['teacher', 'teacher_assistant', 'teacher_dashboard'], true)) {
-            $configModel = new \App\Models\ConfigurationModel();
-            $schoolYear = session()->get('school_year') ?? $configModel->getConfig('school_year');
+            $schoolYear = $this->currentSchoolYearName((string) ($this->schoolYear ?? ''));
             $classSectionId = (int)(session()->get('class_section_id') ?? 0);
 
             if ($classSectionId > 0 && !empty($schoolYear)) {