fix financials

app/Controllers/View/PaymentNotificationController.php

@@ -8,6 +8,7 @@ use App\Models\ConfigurationModel;
 use App\Models\InvoiceModel;
 use App\Models\PaymentModel;
 use App\Models\FamilyGuardianModel;
+use App\Libraries\InvoiceLedgerService;
 use App\Services\EmailService;
 use App\Services\NotificationService;
 
@@ -20,6 +21,7 @@ class PaymentNotificationController extends BaseController
     protected PaymentModel $paymentModel;
     protected FamilyGuardianModel $familyGuardianModel;
     protected EmailService $emailService;
+    protected InvoiceLedgerService $invoiceLedgerService;
 
     public function __construct()
     {
@@ -30,6 +32,7 @@ class PaymentNotificationController extends BaseController
         $this->paymentModel = new PaymentModel();
         $this->familyGuardianModel = new FamilyGuardianModel();
         $this->emailService = new EmailService();
+        $this->invoiceLedgerService = new InvoiceLedgerService();
     }
 
     public function index()
@@ -87,43 +90,19 @@ class PaymentNotificationController extends BaseController
         $year = (int)$now->format('Y');
         $month= (int)$now->format('n');
 
-        // Helper: compute current total balance across invoices for this parent/year
         $computeBalance = function (int $pid) use ($schoolYear): array {
             $db = \Config\Database::connect();
             $rows = $db->table('invoices')
-                ->select('id, total_amount')
+                ->select('id')
                 ->where('parent_id', $pid)
                 ->where('school_year', $schoolYear)
                 ->get()->getResultArray();
-            $paymentsTbl = 'payments';
-            $hasStatus   = $db->fieldExists('status', $paymentsTbl);
-            $hasVoid     = $db->fieldExists('is_void', $paymentsTbl);
 
             $sumBalance = 0.0; $latestId = null;
             foreach ($rows as $ir) {
                 $iid = (int)$ir['id'];
                 if ($latestId === null) $latestId = $iid;
-                $total = (float)($ir['total_amount'] ?? 0);
-
-                $qb = $db->table('payments')->select('COALESCE(SUM(paid_amount),0) AS tot')->where('invoice_id', $iid);
-                if ($hasStatus) {
-                    $qb->groupStart()
-                        ->whereNotIn('status', ['void','voided','refunded','failed','chargeback','declined','reversed','canceled','cancelled'])
-                        ->orWhere('status IS NULL', null, false)
-                       ->groupEnd();
-                }
-                if ($hasVoid) {
-                    $qb->groupStart()
-                        ->where('is_void', 0)
-                        ->orWhere('is_void IS NULL', null, false)
-                       ->groupEnd();
-                }
-                $paid = (float)($qb->get()->getRowArray()['tot'] ?? 0);
-
-                $disc = (float)($db->table('discount_usages')->select('COALESCE(SUM(discount_amount),0) AS tot')->where('invoice_id', $iid)->get()->getRowArray()['tot'] ?? 0);
-                $rfnd = (float)($db->table('refunds')->select('COALESCE(SUM(refund_paid_amount),0) AS tot')->where('invoice_id', $iid)->whereIn('status', ['Partial','Paid'])->get()->getRowArray()['tot'] ?? 0);
-
-                $sumBalance += max(0.0, round($total - $disc - $paid - $rfnd, 2));
+                $sumBalance += (float)($this->invoiceLedgerService->calculateInvoice($iid)['balance'] ?? 0.0);
             }
             return [$sumBalance, $latestId];
         };