fix teacher pages display between school years

app/Views/administrator/teacher_class_assignment.php

@@ -30,13 +30,6 @@
                             </option>
                         <?php endforeach; ?>
                     </select>
-                    <?php $semVal = (string)($semester ?? ($_GET['semester'] ?? '')); ?>
-                    <label for="tcaSemesterSelect" class="col-form-label">Semester</label>
-                    <select id="tcaSemesterSelect" name="semester" class="form-select form-select-sm" style="min-width: 140px;">
-                      <option value="">—</option>
-                      <option value="Fall"   <?= (strcasecmp($semVal,'Fall')===0?'selected':'') ?>>Fall</option>
-                      <option value="Spring" <?= (strcasecmp($semVal,'Spring')===0?'selected':'') ?>>Spring</option>
-                    </select>
                     <button type="submit" class="btn btn-secondary btn-sm">Apply</button>
                 </form>
                 <?php if (isset($isCurrentYear) && !$isCurrentYear): ?>
@@ -183,9 +176,7 @@ document.addEventListener('DOMContentLoaded', function () {
                 position = label.toLowerCase() === 'ta' ? 'ta' : 'main';
             }
             btn.setAttribute('data-position', position);
-            var assignmentSemester = assignment.semester || '';
             var assignmentSchoolYear = assignment.school_year || selectedYear || '';
-            btn.setAttribute('data-semester', assignmentSemester);
             btn.setAttribute('data-school-year', assignmentSchoolYear);
             li.appendChild(btn);
 
@@ -488,7 +479,6 @@ document.addEventListener('DOMContentLoaded', function () {
             var teacherId = removeBtn.getAttribute('data-teacher-id');
             var classSectionId = removeBtn.getAttribute('data-class-section-id');
             var position = removeBtn.getAttribute('data-position');
-            var semester = removeBtn.getAttribute('data-semester') || '';
             var schoolYear = removeBtn.getAttribute('data-school-year') || '';
             var className = removeBtn.getAttribute('data-class-name') || 'this class';
             var teacherName = removeBtn.getAttribute('data-teacher-name') || 'this teacher';
@@ -498,7 +488,6 @@ document.addEventListener('DOMContentLoaded', function () {
                     teacher_id: teacherId,
                     class_section_id: classSectionId,
                     position: position,
-                    semester: semester,
                     school_year: schoolYear
                 });
             }